Use dnf5 on Fedora 40+ #1332
Use dnf5 on Fedora 40+ #1332
Conversation
|
Alternatively, this can be hardcoded in all the fedora-40 configs. And keep doping that with all new ones. Or, we can let it be dnf5 and hardcode it to dnf in all the old ones. |
|
working on changelog entry |
|
Hm, actually ... have you tried it works? |
|
I only tried rendering such a template in Python. Will test to ensure. |
|
ERROR: Config error: /etc/mock/fedora-39-x86_64.cfg: invalid syntax (, line 15) |
|
Tested with F40 and F39 and it works as expected. |
|
For the record, the first attempt created an invalid config and no CI job seems to have noticed that. Perhaps a test should be added that the configs are at least parse-able? |
|
@hroncok I can not find the old testing-farm run now :-/ but it already appeared failed/red actually. But in general, we don't let the test for configs fail the CI. Some of the configs are known to fail; you have to take a look manually into the logs to see the failures. |
|
Ad tests, take a look at the failure here. |
|
I can see |
praiskup
merged commit 9559824
into
rpm-software-management:main
The Jinja statements are only expanded in the values of the config_opts dictionary, not in the keys. The new mock-core-configs version 40.2 contains a Jinja condition in the package_manager value. Therefore, we cannot simply use it as a key in config_opts. Since yum.conf and dnf.conf are aliases (starting from Mock 2.1), and dnf5.conf (starting from Mock 5.0+), we can avoid using the variable as a key entirely. Relates: rpm-software-management/mock@5d620ad326d Relates: rpm-software-management/mock#1332
The Jinja statements are only expanded in the values of the config_opts dictionary, not in the keys. The new mock-core-configs version 40.2 contains a Jinja condition in the package_manager value. Therefore, we cannot simply use it as a key in config_opts. Since yum.conf and dnf.conf are aliases (starting from Mock 2.1), and dnf5.conf (starting from Mock 5.0+), we can avoid using the variable as a key entirely. Relates: rpm-software-management/mock@5d620ad326d Relates: rpm-software-management/mock#1332
|
This broke my own CI strcipt. We use Is this something we should try to fix here, or was this never actually supported? |
|
This is evaluated by https://pypi.org/project/templated-dictionary/ so it should work. Can you open a new issue and put there your whole config so we can reproduce it? |
We e.g. did this in Copr: fedora-copr/copr#3152 |
Fixes https://bugzilla.redhat.com/2264535